[CORL-3216]: replace giphy/react-components with shared GifGrid for Giphy/Tenor #4731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gallant-galileo-14878c canceled.
|
nick-funk
reviewed
Feb 10, 2025
nick-funk
reviewed
Feb 10, 2025
| import { GifSearchInput } from "../GifSearchInput/GifSearchInput"; | ||
| import GiphyAttribution from "./GiphyAttribution"; | ||
|
|
||
| import styles from "./GiphyInput.css"; | ||
|
|
||
| const APPROX_COL_WIDTH = 120; | ||
| const DEBOUNCE_DELAY_MS = 1250; |
There was a problem hiding this comment.
heh, this is roughly what I had before they told me to lower it 🤣
There was a problem hiding this comment.
hmm I just used the same as our current Tenor debounce delay...is it supposed to be lower?
nick-funk
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
These changes:
@giphy/react-components,@emotion/cache, and@emotion/coreEmotionShadowRootsince that was there to support the@giphy/react-componentsThese changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
none
Does this PR introduce any new environment variables or feature flags?
no
If any indexes were added, were they added to
INDEXES.md?n/a
How do I test this PR?
pnpm installto get latest dependency updates inclientYou can test this PR by testing both Giphy and Tenor gif functionality. They can be toggled between in
Configure-->General-->Embedded Media.Their grids should function the same way now. When you search, you should see the gifs and have ability to load more and select your gif of choice to add to a comment. Try different searches and combinations of new searches and loading more.
Were any tests migrated to React Testing Library?
no
How do we deploy this PR?